feat: Make server version available to front-ends #429
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Usage: learn-ocaml-client server-version
or: learn-ocaml-client server-version --min
or: learn-ocaml-client server-version -s http://localhost:8080
or: learn-ocaml-client server-version --local
* Also, ensure that the error
"""
[ERROR] API request not supported by server v.%s using client v.%s
Do you use the latest learn-ocaml-client binary?
"""
is accompanied with 70 as exit code.
See also https://tldp.org/LDP/abs/html/exitcodes.html & /usr/include/sysexits.h
href: bc69958 Co-Authored-By: Léo Segond <[email protected]> Co-Authored-By: Erik Martin-Dorel <[email protected]>
(not two HTTP GET requests)
erikmd
added
the
kind: enhancement
This was referenced Oct 3, 2021
|
Let's close-reopen this one for CI just in case, as it deals with learn-ocaml-client |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This "future-proof PR" is needed to help interoperability in a loosely-coupled way,
so the latest learn-ocaml-client binary (& the learn-ocaml.el front-end depending on it) is compat. with learn-ocaml ↓ version "0.12".
There are now three possible commands:
learn-ocaml-client --versionlearn-ocaml-client server-versionlearn-ocaml-client server-version --min(the min of the previous two)Note: the back-end API is unchanged by this PR.